search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Bundle the app with Meteorite #18

Closed rhysforyou closed 10 years ago

rhysforyou commented 11 years ago

In the current version of the buildpack, the script uses meteor to bundle the app. However we really should be using the mrt tool instead of this, doing otherwise causes the build to fail.

rhysforyou commented 11 years ago

It's worth noting that this fixed #17 for me

rhysforyou commented 11 years ago

Just a heads up regarding this. I threw the fix together in about ten minutes during a hackathon so it probably needs a little refinement before it's ready to merge. I'll have a look at it in the next few days when I'm less mentally exhausted.

RobertLowe commented 11 years ago

+1 This allowed me to deploy a custom build of meteor.

@rpowelll Thanks.

rhysforyou commented 11 years ago

No problem, I'm working on a new Meteor project right now so I'll try to file down the rough edges on this and hopefully get it merged in.

paralin commented 10 years ago

This is no longer required, as mrt does nothing more than the meteor client these days, other than download packages. So, you can bundle with meteor bundle

rhysforyou commented 10 years ago

Yep, I've been meaning to close this pull request for that very reason. Thanks for the reminder.