search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Support for deploying an app where the meteor app folder is a sub-folder of the git repo #19

Open rbabayoff opened 11 years ago

RobertLowe commented 11 years ago

+1 because of things like phonegap

llama commented 10 years ago

This would work if you just deploy the subdirectory using git subtree push --prefix mySubDirectory heroku master.

If it gives trouble about being behind the remote, run git push herokugit subtree split --prefix mySubDirectory master:master -f

You wouldn't be able to use any files in your repo not included in your subdirectory.

paralin commented 10 years ago

+1 llama, but I could just search for a .meteor directory recursively.

gsuess commented 10 years ago

we have an admin app in the sub-directory admin and the front app in the sub-directory app. So I don't think llama's suggestion would work for us as it would break some symbolic links for packages that are shared across the two apps. Searching the meteor directory recursively is also a bad idea in that sense, because it would be ambiguous.

Having a environment variable in which the meteor root directory can be given would be preferable. That way we could deploy it once with that variable set to app and then once with it set to admin.

bitomule commented 10 years ago

I'm also using a sub directory for the app and have custom packages on root, this option is a must for me. Any way I can help?

gsuess commented 10 years ago

@bitomule ive created a fork that supports it at https://github.com/CulturalMe/heroku-buildpack-meteorite, however it doesn't use environment variables, because I couldn't get the detect script to read the those variables. So instead you have commit a file that contains the value of the sub-path to use. It's not ideal but it does the job. Another alternative would be to make the detect script accept anything.

Either way its hacky and not worth pull request so far.

bitomule commented 10 years ago

thanks @gsuess