search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Issues with submodules in Meteorite packages #23

Closed lacco closed 11 years ago

lacco commented 11 years ago

I am having some trouble with deploying my meteorite app using this buildpack. When I deploy my app the first time on Heroku, everything is working fine. After some deployments, one of my packages (https://atmosphere.meteor.com/package/momentjs) isn't loaded anymore, an invocation on the client leads to moment is not defined . Other packages like https://atmosphere.meteor.com/package/router doesn't make any problems, and as soon as I recreate (destroy + create) the application, everything is working fine again.

I tried to find the cause of the issues, so I ran heroku run bash and had a look the packages directory. I compared a "broken" installation to a new one, and found out that the broken lists packages/momentjs -> /tmp/build_334e5susfkcex/.meteorite/packages/momentjs/crapthings/meteor-momentjs/f421f51c2cb40093374a83adb932937da2f991d3/moment (directory is ending with moment which seems wrong) while the new one lists packages/momentjs -> /tmp/build_28500dpgtyenm/.meteorite/packages/momentjs/crapthings/meteor-momentjs/f421f51c2cb40093374a83adb932937da2f991d3).

Since the momentjs package is using a submodule at toplevel, I think this might cause the problems, but I am not so much into Meteor/ Meteorite/ Buildpacks to fix this issue. Do you have any ideas for a workaround/ fix?

lacco commented 11 years ago

I just migrated away from Heroku to modulus.io, and this issue doesn't happen anymore. Closed.