npm install of meteorite fails with node v0.10.21

nate-strauser commented 10 years ago

if my package.json specifies the node engine as "node": "0.10.20" the buildpack works fine, if it is "node": "0.10.x" i get the following:

-----> Fetching custom git buildpack... done
-----> Meteor app app detected
-----> Resolving engine versions
       Using Node.js version: 0.10.21
-----> Fetching Node.js binaries
-----> Installing meteorite with npm

       /tmp/node-node-mlwT/lib/node_modules/npm/node_modules/npm-registry-client/lib/._adduser.js:1
       (function (exports, require, module, __filename, __dirname) { 
                                                                     ^
       SyntaxError: Unexpected token ILLEGAL
           at Module._compile (module.js:439:25)
           at Object.Module._extensions..js (module.js:474:10)
           at Module.load (module.js:356:32)
           at Function.Module._load (module.js:312:12)
           at Module.require (module.js:364:17)
           at require (module.js:380:17)
           at /tmp/node-node-mlwT/lib/node_modules/npm/node_modules/npm-registry-client/index.js:70:49
           at Array.forEach (native)
           at Object.<anonymous> (/tmp/node-node-mlwT/lib/node_modules/npm/node_modules/npm-registry-client/index.js:68:47)
           at Module._compile (module.js:456:26)
 !     Failed to install meteorite -g dependencies with npm

 !     Push rejected, failed to compile Meteor app app

attempts to locally replicate have not succeeded, so maybe its a conflict specific to heroku?

garnermccloud commented 10 years ago

I have the exact same issue with this buildpack and "node": "0.10.21"

mdede commented 10 years ago

+1 (Meteor 0.6.6.2 requires Node v0.10.21 or later.)

emirotin commented 10 years ago

+100 It doesn't deploy with 0.10.21 It deploys with 0.10.20 and fails with Meteor requires Node v0.10.21 or later

So now when I deployed once the project is down and I cannot redeploy with higher version of node

Not reproducible locally and my project has meteor locked to 0.6.6.1 which doesn't require 0.10.21 (this change was introduced in 0.6.6.2) So I assume the buildpack is doing something wrong regarding the meteor version

mdede commented 10 years ago

Works now! Thanks a lot guys.

nate-strauser commented 10 years ago

confirmed working for me also - thanks!

oortcloud / heroku-buildpack-meteorite

npm install of meteorite fails with node v0.10.21 #26