search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

download npm separately #27

Closed areed closed 10 years ago

areed commented 10 years ago

This is a fix for https://github.com/oortcloud/heroku-buildpack-meteorite/issues/26. With Meteor 0.6.6.2, Node 0.10.21 is required, but the run_npm function in bin/compile no longer works with $VENDORED_NODE/bin/npm. I copied the code from the latest version of Heroku's Node buildpack, which downloads NPM separately from Node.

tmeasday commented 10 years ago

Hi @areed - would you like to take ownership of this buildpack? I don't use heroku for Meteor hosting any more, so I'm not really the best person to be doing things like reviewing PRs against it.

I can add you to the oortcloud organisation, or we can point people to your fork if you'd prefer.

areed commented 10 years ago

Hi Tom,

Yes, I can handle that. It's probably best to add me to oortcloud so people don't have to update their BUILDPACK_URL config vars.

Thanks, Andrew

On Wed, Oct 23, 2013 at 9:45 PM, Tom Coleman notifications@github.comwrote:

Hi @areed https://github.com/areed - would you like to take ownership of this buildpack? I don't use heroku for Meteor hosting any more, so I'm not really the best person to be doing things like reviewing PRs against it.

I can add you to the oortcloud organisation, or we can point people to your fork if you'd prefer.

— Reply to this email directly or view it on GitHubhttps://github.com/oortcloud/heroku-buildpack-meteorite/pull/27#issuecomment-26966497 .

tmeasday commented 10 years ago

Awesome, I've added you to the contributors. Thanks so much :)

gjolund commented 10 years ago

:+1: works for me @areed