oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Push rejected, no Cedar-supported app detected #30

Closed solars closed 10 years ago

solars commented 10 years ago

Hi there,

I've added: heroku config:add BUILDPACK_URL=https://github.com/oortcloud/heroku-buildpack-meteorite.git

To my app and set the Root URL, however, I always get Push rejected, no Cedar-supported app detected.

Do I need a particular layout or files? Right now I'm testing with these files:

client/ server/ leaderboard.js leaderboard.html leaderboard.css

Thanks, Christoph

solars commented 10 years ago

can anyone help?

gjolund commented 10 years ago

@solars I would highly recommend using modulus meteor deployment instead https://modulus.io/codex/meteor_apps

This is how I currently deploy all of my production meteor applications

solars commented 10 years ago

sorry, but I'm trying to deploy to heroku? I'm not looking for an alternative

mdede commented 10 years ago

Try including package.json file in the root of your project with the following content:

{
  "name": "Leaderboard or whatever",
  "version": "0.0.1",
  "engines": {
    "node": "0.10.21"
  }
}
solars commented 10 years ago

I'm getting the same result with this package.json, Push rejected, no Cedar-supported app detected

solars commented 10 years ago

what else could be wrong? I still get -----> Fetching custom git buildpack... done

! Push rejected, no Cedar-supported app detected

solars commented 10 years ago

hi,

hmmm did you delete your comments? can't see them online :)

I don't currently have a procfile, does main.js need to be the name of the main meteor file?

Thanks, Christoph

On Thu, Jan 2, 2014 at 10:25 PM, Andre Lewis notifications@github.comwrote:

Scratch that. I realized that the buildpack wasn't associated with the right app. Doh.

— Reply to this email directly or view it on GitHubhttps://github.com/oortcloud/heroku-buildpack-meteorite/issues/30#issuecomment-31485937 .

mrmowgli commented 10 years ago

Hi Solars, yeah, I deleted them because I realized I didn't have the buildpack associated with the right application. package.json is currently ignored so that shouldn't be an issue.

I DID have to add this section to the Procfile after I tooled around the actual instance:

web: .meteor/heroku_build/bin/node .meteor/heroku_build/app/main.js

For whatever reason, I think this only gets generated when you do the initial heroku create.

mrmowgli commented 10 years ago

It helped to dig around and see what was actually generated:

heroku run bash -a  <app name>
solars commented 10 years ago

hmm now I'm a bit confused.. what do I have to do from start again? :) I'm not sure where main.js comes from...

mrmowgli commented 10 years ago

main.js is the file that gets generated by meteor bundle, after it minifies and compiles everything. I had an existing heroku app set up, so it caused problems with the initial instructions. After logging in to the actual deploy I realized that I needed to rerun the command:

heroku config:set BUILDPACK_URL=https://github.com/oortcloud/heroku-buildpack-meteorite.git  -a app-name-here

Now it was bundling properly, but the main.js wasn't found, so I looked in the running instance using:

heroku run bash -a  <app name>

and found that it gets deployed to: .meteor/heroku_build/app/main.js

Does that make more sense?

solars commented 10 years ago

it does.. however, I still get "! Push rejected, no Cedar-supported app detected" when pushing ... weird there is nothing there if I run the bash cmd

DominikGuzei commented 10 years ago

Hey @solars , do you have your .meteor folder checked into your git repository? I just had the same problem and could solve it by adding .meteor and pushing again!

paralin commented 10 years ago

Fixed? Or not a real issue?

maxko87 commented 10 years ago

@DominikGuzei @solars adding .meteor to the project directory fixed the "! Push rejected, no Cedar-supported app detected" bug for me as well.