oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Stable and updated implementation for newest Meteor versions #32

Closed paralin closed 10 years ago

paralin commented 10 years ago

This fixes all of the problems with outdated node versions and is tested to work out of the box with a stock Meteorite project.

Furthermore it now fetches the latest Node.JS stable version from https://semver.io/node/resolve?range=stable

You can define somewhat semantic values for the range, like https://semver.io/node/resolve?range=0.11.x

It fetches this value and downloads from the new Heroku repository proxy, which is much faster than using the direct amazon S3 url.

This update follows the pattern of the latest Heroku Node.JS buildpack.

areed commented 10 years ago

Excellent, lots of good updates here. Any reason not to include jq under vendor/ and use it to parse package.json like the official Heroku NodeJS buildpack?

paralin commented 10 years ago

I don't see why not. I didn't get that in in this commit but I could implement that. I just added a variable for the interpreted node version ranges and will fill that in later.

The package.json interpreter in the current version doesn't work at all anyway, so I see it as an addition to add support for that again.

zeke commented 10 years ago

Nice work @kidovate and @areed! I'm really glad to see my work on the node buildpack and semver.io reaching the Meteor community. :stars: