oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Updating Node version. #33

Closed royletron closed 10 years ago

royletron commented 10 years ago

Meteor 0.7+ requires Node 0.10.22 to run and it seems the "stable" version still pulls 0.10.21.

mrmowgli commented 10 years ago

As they mention on their change log, Release 0.7.0.1 applies a patch to Node versions 0.0.22 - v0.10.24, so the current version of the buildpack should support one of those, most likely the v0.10.24 build.

areed commented 10 years ago
curl --silent --get --data-urlencode "range=stable" https://semver.io/node/resolve

from line 80 yields "0.10.24" for me

viveksjain commented 10 years ago

The stable version now is 0.10.25, which doesn't work with the latest Meteor. I get the log message

This version of Meteor contains a patch for a bug in Node v0.10.
The patch is against only versions 0.10.22 through 0.10.24.
You are using version v0.10.25 instead, so we cannot apply the patch.
AdrienLemaire commented 10 years ago

Same problem here

EDIT 01/30: Issue solved, not getting any error on Heroku anymore

garnermccloud commented 10 years ago

+1. Getting the same issue. Looked through the Meteor develop branch and they put through a fix for 0.10.25. Either have to wait for that, or figure out a way to set the node version for this buildpack.

viveksjain commented 10 years ago

I've forked the repo and manually set the node version to 0.10.24 (see commit here), and that is what I am using for now. However, I don't know if that is the best way to deal with the issue. It would require updating the node version manually for every new release of Meteor. Maybe there should be a simple website that just returns the version of node that works with the latest Meteor (maybe open an issue at meteor/meteor, or if there is enough interest I'd be willing to put something together). Then the script could just get the version of node.js referenced on that website.

garnermccloud commented 10 years ago

@viveksjain Yeah I agree, there probably should be a way that this buildpack can pull the most current version of node that Meteor uses. I wouldn't mind helping out to get this working

@Fandekasp I'm still getting the same node version issue. How did you fix yours?

AdrienLemaire commented 10 years ago

@garnermccloud I didn't do anything, must have been resolved on Heroku side, sorry ^^

viveksjain commented 10 years ago

Actually it looks like the bug in Node v0.10 has been fixed upstream, so we won't need to worry about the node version in the future. As a result, I think just specifying the version manually for now is an OK stopgap measure.

garnermccloud commented 10 years ago

It's now working for me. Wasn't setting the root_url correctly when I redid it early today. Thanks guys

paralin commented 10 years ago

This shouldn't be necessary anymore with the new semvar buildpack

viveksjain commented 10 years ago

@kidovate could you please clarify? Perhaps I'm misunderstanding, but the issue is precisely because of the new semvar buildpack, since the latest Meteor version doesn't yet support the latest stable node.js version.

paralin commented 10 years ago

There's a single var you can change to change the buildpack node version (which for me works fine with "stable").. If meteor needs a specific version just set it there

paralin commented 10 years ago

I see you did change it in a fork - but for me stable still works fine. What is wrong with "stable"?

viveksjain commented 10 years ago

See my previous comment. It works, but I think websockets is disabled because the patch cannot be applied.

paralin commented 10 years ago

Hmm... Perhaps we can just use the latest version of Node?

paralin commented 10 years ago

I've come up with a solution - in my branch (and pull request), latest is the default semvar (which is compatible with Meteor).

Because we don't have anything available to us that can parse JSON yet, you can now specify the node version for semvar in a file named nodeversion (optional).

paralin commented 10 years ago

See #35

paralin commented 10 years ago

Recently fixed.

shravansing commented 10 years ago

Looks like there is still a problem .. I upgraded to 0.7.1.2. And i can still see te problem .

paralin commented 10 years ago

@shravansing Don't use versions, use the master branch. HEAD.