search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Version Fixes (Semantic Node Version File) #35

Closed paralin closed 10 years ago

paralin commented 10 years ago

Because stable is a version of Node that is incompatible with Meteor websockets, 0.10.24 is now the default semver. This version is compatible with Meteor and the sockets patch.

That said, it is really a required feature to be able to specify the node version. Furthermore, with semver.io, it would be a waste to not allow the user to specify what version of node to use. In my previous commits I left the variable blank, which triggers the script to just use the default. I did this in lieu of the original method of parsing a package.json file to determine which Node version to use.

Because we don't have anything available to us that can parse JSON in the environment yet, I instead opted to have a simpler form of version specification - you can just set your semver.io compatible range in nodeversion, a file in your project's root.

areed commented 10 years ago

@tmeasday Could you give @kidovate push access for this repo? He's been doing the maintenance lately.

tmeasday commented 10 years ago

Oh, I thought he already had access. Done.

paralin commented 10 years ago

Thanks @areed and @tmeasday. What do you think of the patch? Do we scrap the package.json or do we find some super lightweight way to parse json?

paralin commented 10 years ago

Merging it just as a temporary fix... we can discuss package.json stuff later on

shravansing commented 10 years ago

the fix is not included in 0.7.1.2

paralin commented 10 years ago

@shravansing which fix and that version of what?