Meteorite submodule clone issue

paralin commented 10 years ago

This project works fine locally, but when pushing to heroku I get a bunch of missing files:

      [1mDone installing smart packages[22m
       Building meteor bundle
       iron-router: updating npm dependencies -- connect...
       xml2js: updating npm dependencies -- xml2js...
       mongodb-aggregation: updating npm dependencies -- mongodb...
       npm: updating npm dependencies -- html-md...
       Errors prevented bundling:
       While building package `pen`:
       error: File not found: lib/src/font/fontello.eot
       error: File not found: lib/src/font/fontello.svg
       error: File not found: lib/src/font/fontello.ttf
       error: File not found: lib/src/font/fontello.woff
       error: File not found: lib/src/pen.css
       error: File not found: lib/src/pen.js
       error: File not found: lib/src/markdown.js
tar: /app/tmp/cache/bundle.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: Child returned status 2
tar: Exiting with failure status due to previous errors

 !     Push rejected, failed to compile Meteor app app

paralin commented 10 years ago

Any idea why this would happen @areed or @tmeasday?

areed commented 10 years ago

symlinks?

paralin commented 10 years ago

looks to me like it might not be cloning the submodule properly.

paralin commented 10 years ago

Confirmed @areed, Meteorite is not properly cloning the subrepo of the meteor-pen repository in the buildpack, while it works fine in the version on my laptop.

If I remove the submodule and make it a folder instead, it works properly. You can see the difference between my repo and the broken repo.

paralin commented 10 years ago

I tried:

Deleting ~/.meteorite/ in the buildpack, AND using my repo for meteor-pen, which worked
Switching the buildpack git back to this one, AND deleting smart.lock, AND using my repo - worked
Deleting smart.lock, switching smart.json back to the original PEN repo, and the buildpack to this one - did not work
Using this buildpack, deleting smart.lock, and using my own pen repo - worked

Note regardless of what repo version I use for Pen it works fine on my laptop but not in the buildpack. These tests I've done seem to isolate the presence of the submodule as the issue - it is not being cloned properly. Even when I delete ~/.meteorite/ to force a clean clone (although I believe it's ephemeral and not even relevant to do that), it still doesn't seem to work properly.

paralin commented 10 years ago

Issue is caused by having a submodule with SSH style syntax

oortcloud / heroku-buildpack-meteorite

Meteorite submodule clone issue #37