search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Handle npm's new cert bug #40

Closed viveksjain closed 10 years ago

viveksjain commented 10 years ago

Fixes #39.

paralin commented 10 years ago

I do not see this issue. When running the buildpack everything downloads fine. Are you sure this fix is necessary?

paralin commented 10 years ago

This solution is potentially harmful, NPM doesnt seem to be fetching using HTTPS using this fix. Are you sure there isn't a better way to handle the error? I still don't see any issues without the fix.

viveksjain commented 10 years ago

npm still uses HTTPS with this solution, but just uses the CA built-in to your operating system’s copy of OpenSSL. But npm has switched to an older cert that works without this fix, so you're right, this should no longer be necessary. http://blog.npmjs.org/post/78165272245/more-help-with-self-signed-cert-in-chain-and-npm has more details.