search

oortcloud / heroku-buildpack-meteorite

MIT License
189 stars 97 forks source link

Installing additional npms #6

Closed kasima closed 11 years ago

kasima commented 11 years ago

Looks like the run_npm() lines are commented out in bin/compile. Would this install npm's I've installed with a package.json file at root? Is there another way to handle this when deploying to heroku with this build back?

Thanks!

tmeasday commented 11 years ago

It could theoretically, although meteor won't like it if you put a package.json file there, so that approach is out of luck.

I had some ideas about other ways we could get npm modules installed on heroku but never got around to implementing it (read: I haven't needed it yet). I'll happily accept a PR to get it working; although I'm reliably informed that an upcoming version of meteor will have some kind of support for npm, so unless it's urgent, if I was you I'd wait until we see what that looks like first.

kasima commented 11 years ago

It's probably not too urgent but if I pick at it, I'll let you know. Thanks!

davidascher commented 11 years ago

Any update on this? I'm a bit stuck w/o it. Not a huge deal, but thought I'd ask if you'd found workarounds.

tmeasday commented 11 years ago

Nothing from my end as yet