search

oortcloud / meteorite

Installer & smart package manager for Meteor
http://oortcloud.github.com/meteorite/
MIT License
841 stars 106 forks source link

mrt add does not activate subpackages #138

Closed gjolund closed 11 years ago

gjolund commented 11 years ago

For any package that contains subpackages ( router, packages-bootstrap ) the mrt add command does not activate the subpackages.

Replicate Bug $ mrt create bug $ cd bug $ mrt add packages-bootstrap $ mrt list --using

You will only see packages-bootstrap and not any of the subpackages ( githubReadme, pageguide, proxino, bootboxjs ). If you check in .meteor/meteorite/packages you will see that the packages have been downloaded.

This means that I have to execute an mrt add command for each subpackage in order for it to begin working. Is this by design or a bug?

tmeasday commented 11 years ago

@austinrivas you are right about everything but the last point.

Just like you don't need to meteor add 'account-base' to use it, (you can just add 'accounts-ui'), you don't need to explicitly add a package that is a dependency of another. If things aren't working then that's a bug somewhere, but everything sounds like it should be working the way you have described it.

gjolund commented 11 years ago

Thanks @tmeasday, I took a look at your meteor-router/package.js and realized that I needed to add the meteorite smart package dependencies there with api.use(), I thought that was just for Meteor.

tmeasday commented 11 years ago

Ahh. Yes. It's sort of annoying to have to do it twice, but I feel like it's better to add to Meteor's existing syntax than override it.

gjolund commented 11 years ago

I appreciate the help @tmeasday , I'm doing my best to get through the packages api without documentation, your packages have been a huge help.

If you don't mind I'm having another small issue with including packages from a higher directory such as

"packages-bootstrap": {"path":".."}

For whatever reason its not including the package and I'm receiving undefined errors for my class methods

If you have second can you take a look at https://github.com/austinrivas/meteor-packages-bootstrap and give me your thoughts?

tmeasday commented 11 years ago

Hey,

You probably just need to include 'packages-bootstrap' in the .meteor/packages of your example app.

On Friday, 31 May 2013 at 10:36 AM, Austin Rivas wrote:

I appreciate the help, I'm doing my best to get through the packages api without documentation, your packages have been a huge help. If you don't mind I'm having another small issue with including packages from a higher directory such as
"packages-bootstrap": {"path":".."} For whatever reason its not including the package and I'm receiving undefined errors for my class methods If you have second can you take a look at https://github.com/austinrivas/meteor-packages-bootstrap and give me your thoughts?

— Reply to this email directly or view it on GitHub (https://github.com/oortcloud/meteorite/issues/138#issuecomment-18717230).

gjolund commented 11 years ago

That did it, thanks a ton man!