oortcloud / meteorite

Installer & smart package manager for Meteor
http://oortcloud.github.com/meteorite/
MIT License
841 stars 106 forks source link

Should `mrt` be available in PATH during tests or not? #241

Closed yeputons closed 10 years ago

yeputons commented 10 years ago

There are two places where mrt is runned as a separate process:

  1. /spec/lib/atmosphere.js. The baseCommand variable specifies that mrt should be available in PATH.
  2. /spec/lib/runner.js. The meteoriteExecutable variable stores absolute path to mrt.js.

If there is no mrt command in PATH, tests will fail. This is not specified in document - you ask for npm install to be run only. I think atmosphere.js should be modified in a way similar to runner.js.

tmeasday commented 10 years ago

No, this was always a mistake. Thanks for fixing it.