Open colinsullivan opened 10 years ago
When a package has a submodule with an SSH github URL like this:
https://github.com/colinsullivan/meteor-blueimp-tmpl/blob/af80498ec7b2366985bef87b0b97eddfc1e48c59/.gitmodules
And the current user's SSH keys are not set up with github, the submodule is not downloaded and there is no error message.
This one took me a while to figure out.
Changing the module URL to the HTTP github URL like this:
https://github.com/colinsullivan/meteor-blueimp-tmpl/commit/0a740307917627d88677cdc09f04af87f85cc55f
Works as expected.
Whew! Handling this case with an error message would be helpful for some poor souls in the future.
When a package has a submodule with an SSH github URL like this:
https://github.com/colinsullivan/meteor-blueimp-tmpl/blob/af80498ec7b2366985bef87b0b97eddfc1e48c59/.gitmodules
And the current user's SSH keys are not set up with github, the submodule is not downloaded and there is no error message.
This one took me a while to figure out.
Changing the module URL to the HTTP github URL like this:
https://github.com/colinsullivan/meteor-blueimp-tmpl/commit/0a740307917627d88677cdc09f04af87f85cc55f
Works as expected.
Whew! Handling this case with an error message would be helpful for some poor souls in the future.