search

oortcloud / meteorite

Installer & smart package manager for Meteor
http://oortcloud.github.com/meteorite/
MIT License
841 stars 106 forks source link

Smart.json in non-standard location #258

Closed christianbundy closed 10 years ago

christianbundy commented 10 years ago

Instead of polluting the root of the project directory, I've moved smart.json, routes.js, and collection.js to config directory. Is there any way to get meteorite to install packages from a my non-standard location, or am I locked into using /smart.json?

paralin commented 10 years ago

This is a pretty major change. There is currently no code that allows you to change where these things are stored.

Do you consider .gitignore and .gitattributes and .gitmodules pollution as well?

christianbundy commented 10 years ago

It looks like it would be a pretty minor change to me, but maybe I'm missing something.

The .git* files are location-specific, so their placement should be deliberate and intentional. Placing a .gitignore file in / means something different than placing a .gitignore file in /.meteor, so moving it wouldn't make sense to move them to a different directory. Unlike smart.json and smart.lock, git configuration files are also hidden, which means that they won't show up unless you're in the habit of using ls -A every time you want to list the contents of a directory.

I totally wasn't meaning to criticize the project – I really appreciate all the work that's been put into it, I was just looking for a way to get the non-hidden non-directory-specific configuration files out of the project root.

paralin commented 10 years ago

I was just wondering why you would have utility like files (like smart.json and smart.lock) moved, while you are fine with git related files.

If you want to fork the repo and make a change to that line, that would be fine. Note you also have to update the path to the .meteor directory in the code, I would assume.

christianbundy commented 10 years ago

I'd rather that git related files be in their own folder, but they're location-specific and hidden so they aren't really cluttering the project root much. I'll let you know if I find an elegant solution. Thanks for the tips!