oortcloud / meteorite

Installer & smart package manager for Meteor
http://oortcloud.github.com/meteorite/
MIT License
841 stars 106 forks source link

Dependency resolution inconsistent #266

Closed michaelbishop closed 10 years ago

michaelbishop commented 10 years ago

I was using a published packaged called accounts-entry which has two dependencies:

✓ just-i18n
    tag: https://github.com/subhog/meteor-just-i18n.git#v0.1.1
✓ accounts-t9n
    tag: https://github.com/softwarerero/meteor-accounts-t9n.git#v0.0.2

I need to make some changes. So I forked it, made changes and updated it with my github repository like so:

    "accounts-entry": {
        "git": "https://github.com/michaelbishop/meteor-accounts-entry.git"
    },

However, when I run mrt update I get these errors:

✓ just-i18n
    branch: git@github.com:BeDifferential/meteor-just-i18n.git#blaze
✓ accounts-t9n
    branch: git@github.com:BeDifferential/meteor-accounts-t9n.git#fix-just-i18n
Problem installing just-i18n
  ✘ [latest] conflicts with [branch: git@github.com:BeDifferential/meteor-just-i18n.git#blaze]
Can't resolve dependencies! Use --force if you don't mind mrt taking a wild guess and running your app anyway.

Notice the repository locations and branches have changed to the BeDifferential ones instead of the published ones like it was using. Why would mrt use unpublished github packages instead of published dependencies?

michaelbishop commented 10 years ago

Nevermind, I realized that the published version is behind master. So smart.json in the master branch is referencing github pages instead of published packages. I didn't realized dependencies could be pinned in that manner. Learned something new. Thanks for the awesome tools!