search

oortcloud / node-ddp-client

A callback style DDP (Meteor's Distributed Data Protocol) node client.
Other
263 stars 80 forks source link

Ddp pre1 emgee3 #10

Closed emgee3 closed 11 years ago

emgee3 commented 11 years ago

So I finally got around to working on pre1 support for the DDP client. I added the 'added' 'removed' 'changed' and 'ready' commands.

It's definitely not fully pre1 compliant. There's no EJSON support, 'error', 'addedBefore' or 'movedBefore', though the last two aren't actually implemented in Meteor yet.

I'm not sure if you want to merge this or not, seeing how it is incomplete, but it's more complete than the previous 2 pull requests and both subscriptions and methods work. I've been meaning up update to the latest version of Meteor, but needed the DDP client update first.

emgee3 commented 11 years ago

And today I had a chance to add EJSON support, but we should go over how to add this. How I did it was packaged up Meteor's EJSON smart package as it's own node module and require()'d it. Not sure if you want to include these files, or break it out as it's own node module, or have other ideas how you want to do it.

tmeasday commented 11 years ago

Thanks @emgee3 ! @sarfata are you happy with this? If so I'll do a release of ddp (I guess I'll have to update atmosphere too :) )

@emgee3 -- have you spoken to any of the core devs about the EJSON stuff? Probably best if they put it on NPM themselves so they can take responsibility for maintaining it..

sarfata commented 11 years ago

This looks great. Thanks @emgee3. I was completely under-water last week but will try this in more depth sometime soon. Dont wait for me for a release though @tmeasday.

Would be nice to have some tests: I can see the code for the new methods getting complicated quite quickly. (food for thoughts)

tmeasday commented 11 years ago

Yes. I won't have the time but I'd love for one of you guys to take over.

Happy to give up control of the npm module too

On Monday, 18 March 2013 at 9:51 PM, Thomas Sarlandie wrote:

This looks great. Thanks @emgee3 (https://github.com/emgee3). I was completely under-water last week but will try this in more depth sometime soon. Dont wait for me for a release though @tmeasday (https://github.com/tmeasday). Would be nice to have some tests: I can see the code for the new methods getting complicated quite quickly. (food for thoughts)

— Reply to this email directly or view it on GitHub (https://github.com/oortcloud/node-ddp-client/pull/10#issuecomment-15048625).

emgee3 commented 11 years ago

@tmeasday that sounds better than me maintaining such a package. I'll ask. As far as taking over ddp-node-client, I'm happy to help but I don't think I'm technically competent enough to take over.

@sarfata testing is obviously a great idea, and I was thinking more error checking is also in order.