search

oortcloud / node-ddp-client

A callback style DDP (Meteor's Distributed Data Protocol) node client.
Other
263 stars 80 forks source link

Error thrown when username is not registered #31

Closed patrickdevivo closed 10 years ago

patrickdevivo commented 10 years ago

I opened up an issue here: https://github.com/phillyqueso/node-srp/issues/1 on the SRP code that this module uses.

Trying to login with a bad username throws an error, instead of passing one to the login callback. Can this behavior be changed? Seems a bit messy.

Thanks! Patrick

Tarang commented 10 years ago

Thanks for finding this. The SRP is a two stage authentication method, so we assumed the errors popped in at the final stage. But if there is no user it can't proceed so the error needs to be handled mid-way.

Fixed in the latest version.