search

oortcloud / node-ddp-client

A callback style DDP (Meteor's Distributed Data Protocol) node client.
Other
263 stars 80 forks source link

Update `faye-websocket` version #77

Closed tmeasday closed 8 years ago

tmeasday commented 8 years ago

Would be neat to bump this. 0.9.4 doesn't support SNI (which is needed for Galaxy).

0.11.0 seems to work fine.

vsivsi commented 8 years ago

Thanks for the suggestion. I'm working through a list of Meteor 1.3 related issues right now, but I'll try to take a look at this in the next few days. Do you have an application where you can test this out from a dev branch? I'm not currently using Galaxy.

mayvn10 commented 8 years ago

@vsivsi - @tmeasday was helping me with this. I filed a support request with Galaxy and he filed this issue request.

In short, I have an app in development where I am using the node-ddp-client package to connect to Galaxy with SSL. However, the connection continues to fail.

tmeasday commented 8 years ago

@vsivsi sure! This snippet will show the issue:

var DDPClient = require("ddp");

var ddp = new DDPClient({ 
  url: 'wss://atmospherejs.com/websocket',
});

ddp.connect(function(error) {
  if (error) {
    console.log('DDP connection error!', error);
    return;
  }

  console.log('connected')
});

If you mess around in node_modules so that faye-websocket@0.11.0 is installed, you'll notice it works fine.

vsivsi commented 8 years ago

Okay, I think everything is ready to go on master. I've tested with the code above, plus a couple of apps that I have running locally, with no issues. Can someone else give it a try? It's ready to publish as soon as I hear back...

tmeasday commented 8 years ago

Well it works for me! I don't have any real test apps that use this package properly though :)

vsivsi commented 8 years ago

Great. I'm actually scanning through the issues on this project to see if there are any other no-brainers queued up that haven't been addressed yet and can be easily resolved. Once I'm done with that, I'll publish.

vsivsi commented 8 years ago

0.12.0 published to npm

mayvn10 commented 8 years ago

Great work - thank you!