ooxi / violetland

An open source cross-platform game similar to Crimsonland
https://violetland.github.io/
Other
66 stars 16 forks source link

Change `LifeForm::ReloadSpeedMod` #118

Closed ooxi closed 8 years ago

ooxi commented 8 years ago

Old formula

reload-speed-mod_old(agility) = 1 / agility

New formula

reload-speed-mod_new(agility) = 2 / 2 * agility

reloadspeedmod

reload-speed-mod_old is blue, reload-speed-mod_new is red. x-axis is agility, y-axis is ReloadSpeedMod. A LifeForm's initial agility is one and increases slowly

ooxi commented 8 years ago

@bla-rs could you please describe the gameplay implications of this change? I'm not entirely sure, whether this change is correct since you could simply return getAgility() instead of 2.0f / 2.0f * getAgility().

bla-rs commented 8 years ago

This change is plainly wrong. It increases the reload time when you increase agility. There should be braces around the last part but even if, there is nothing wrong with the original formula. I have no idea, why i even changed this :) ... you can discard this commit

ooxi commented 8 years ago

OK I thought so :) this is the only change that did not make sense.