ooxi / violetland

An open source cross-platform game similar to Crimsonland
https://violetland.github.io/
Other
66 stars 15 forks source link

Fix CMake gettext detection #137

Closed ooxi closed 7 years ago

ooxi commented 7 years ago

REQUIRE_BINARY will be invoked with the result of a find_program invocation. The old REQUIRE_BINARY implementation assumed, an unfound program would result in the definition of a second variable VAR-NOTFOUND. Instead the actual behaviour of find_program will assign the value VAR-NOTFOUND to the variable VAR. Thus the new implementation will catch errors finding programs while the old did not.

Moreover the error message is fixed, old output was Could not find binname while the new will substitue the variable binname thus resulting in e.g. Could not find xgettext.