search

ooyala / barkeep

The friendly code review system.
getbarkeep.org
1.42k stars 145 forks source link

Ugly font (Ubuntu Monospace) #218

Open edanaher opened 12 years ago

edanaher commented 12 years ago

I suppose it's possible that I'll get used to it, but currently, I think Ubuntu Monospace is just plain ugly. In particular, the m is bad enough that I'm probably going to throw a custom stylesheet at it to not have to look at it, and the w is also pretty bad.

I'll admit that the Ubuntu non-monospaced font is pretty nice, and looking at 48 pt monospaced at http://font.ubuntu.com/ isn't completely terrible (except for m and w), but small-ish Ubuntu Monospace makes me want to not do code reviews.

What was wrong with Vera Sans Mono?

cespare commented 12 years ago

I've sunk maybe a dozen hours into making the commit view fonts work well. I don't remember all the details, but any solution needs to have the following properties:

See, for example, these commits for some of the history here:

If you can get everything working using Bitstream Vera Sans Mono, please submit a pull request.

edanaher commented 12 years ago

Blech... didn't fonts used to be a solved problem? Or was I just not paying enough attention?

You're right, I probably don't actually want to spend all the time to make sure that every broken browser/OS combination works. I'll probably give it a week to get used to it, and if I don't, use custom CSS rather than trying to fix it properly. :(

cespare commented 12 years ago

Assigning to Brian, who has promised to clean up the diff view by removing all tables, after which changing fonts back should be no big deal.

philc commented 12 years ago

I also don't like the font, but I don't have the experience to suggest an alternative.

zdyn commented 12 years ago

I don't have much experience either, although I recently discovered Cousine, available on Google Web Fonts and comes with italic and bold variants. Here is Ubuntu Mono and Cousine compared side-by-side.

cespare commented 12 years ago

Nice, I'll give it a shot when I get a chance.

Part of the problem is that google fonts doesn't let you search by monospace :|

Another thing I forgot to mention is that it's imperative for our font to have a dotted/slashed 0, and for l, |, I, and 1 to be easily distinguishable. Cousine seems to satisfy those properties as well.