URL encode DB parameters in run_migrations.rb

ooyala / barkeep

The friendly code review system.

getbarkeep.org

1.42k stars 145 forks source link

URL encode DB parameters in run_migrations.rb #434

Open thomasjenkins opened 11 years ago

thomasjenkins commented 11 years ago

If you have characters in your DB password that would require escaping (e.g. "#" => %23) the run_migrations.rb script will explode using the constructed mysql2 URI. However, the unencoded versions of the parameters are needed elsewhere so you can't just put the encoded versions in environment.rb.

philc commented 11 years ago

Nice find Thomas. If you have this working locally, could you send us a pull request?

thomasjenkins commented 11 years ago

I ended up just one-off working around this, but I'll try to put something together later today. I'm more of a Python guy than a Ruby guy so I'll have to orient my self with the URL encoding packages.