search

ooyala / barkeep

The friendly code review system.
getbarkeep.org
1.42k stars 145 forks source link

support different email for signin #447

Open kumm opened 11 years ago

kumm commented 11 years ago

Now barkeep thinks my gmail address for signin is the same to the email address in my commits. This is not the case.

I've introduced a new login field for signin, and made current email address editable. Just the signin process changed slightly, everything works as before. Except you can configure your email address. As before, all outgoing mail sent to this address, and the commits have to contain this address too. A migration also included to fill the new login field to the current email, so existing users works after this change.

In general, this is another apporach to issue #426

netwjx commented 11 years ago

+1

Danesz commented 11 years ago

Hi kumm,

how can I use your modifications in barkeep? I cloned your master barkeeper repo and installed it, but the login page is always the google's page.

Thanks!

kumm commented 11 years ago

I have not changed the authentication method. It's oauth with google. So the login page is always the google's page. You have to login by google. The only thing changed, is you don't have to use the same email address for login, and for the git commits.

Danesz commented 11 years ago

ok, thank you!

esamattis commented 10 years ago

I tried merging this on top of bb24f2263ede7074319e1a69a0b6de2dfdafa692 but I got NoMethodError - undefined method login for #<User:0x0000000347eb88> error on /settings.

Full stack trace https://gist.github.com/epeli/10867578

esamattis commented 10 years ago

Update: It seems that I just forgot to run the migrations. Ok to merge!