ooyala / barkeep

The friendly code review system.
getbarkeep.org
1.42k stars 145 forks source link

NoMethodError at deliver_comment_emails when commenting a line in a renamed file #449

Open kumm opened 11 years ago

kumm commented 11 years ago

backtrace:

NoMethodError undefined method `lines' for nil:NilClass
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:33:in `block (2 levels) in evaluate_source'
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:30:in `each'
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:30:in `map'
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:30:in `block in evaluate_source'
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:24:in `each'
/var/lib/barkeep/barkeep/lib/../views/email/comment_email.erb:24:in `evaluate_source'
<..>
.../gems/tilt-1.3.3/lib/tilt/template.rb:76:in `render'
/var/lib/barkeep/barkeep/lib/emails.rb:221:in `render_template'
/var/lib/barkeep/barkeep/lib/emails.rb:190:in `comment_email_body'
/var/lib/barkeep/barkeep/lib/emails.rb:53:in `send_comment_email'
/var/lib/barkeep/barkeep/resque_jobs/deliver_comment_emails.rb:37:in `perform'
<..>
kumm commented 11 years ago

The problem is 'file_name_after' used in emails.rb, but 'file_name_before' at comment save.

philc commented 11 years ago

Nice find!