ooyala / barkeep

The friendly code review system.
getbarkeep.org
1.42k stars 145 forks source link

Update eventmachine dep to 1.0.0+, 0.12.10 won't build @Debian. #459

Open michalrus opened 11 years ago

michalrus commented 11 years ago

See https://github.com/eventmachine/eventmachine/issues/345 -- this won't build using bundle install, I'm getting the same error as people in mentioned issue.

compiling rubymain.cpp
rubymain.cpp: In function ‘VALUE t_connect_server(VALUE, VALUE, VALUE)’:
rubymain.cpp:468:42: error: format not a string literal and no format arguments [-Werror=format-security]
rubymain.cpp: In function ‘VALUE t_bind_connect_server(VALUE, VALUE, VALUE, VALUE, VALUE)’:
rubymain.cpp:488:42: error: format not a string literal and no format arguments [-Werror=format-security]
cc1plus: some warnings being treated as errors
make: *** [rubymain.o] Error 1

Further research:

bryenbegg commented 11 years ago

Been able to reproduce this as well. This is the sole reason stopping me using barkeep in my production development teams. 64-bit is a necessity in this day and age (especially with enterprise servers).

jonny64 commented 10 years ago

same error

uname -a Linux 3.2.0-4-686-pae #1 SMP Debian 3.2.51-1 i686 GNU/Linux cat /etc/debian_version 7.2