search

op-ent / api

https://github.com/op-ent/op-ent/tree/main/apps/api
GNU General Public License v3.0
5 stars 1 forks source link

Setup docker (Close #12) #13

Closed Micorksen closed 2 years ago

Micorksen commented 2 years ago

Pull request for the issue #12

Micorksen commented 2 years ago

Dockerfile, .dockerignore are missing. Apply the tips and tricks part of the cookbook too.

If I don't build a custom image, why do I need to set a Dockerfile ? Adding a .dockerignore right on the way !

florian-lefebvre commented 2 years ago

Can you please make any modifications to add https://docs.adonisjs.com/cookbooks/dockerizing-adonis#tips-and-tricks please?

Micorksen commented 2 years ago

Every change is made !

florian-lefebvre commented 2 years ago

Almost! I added some reviews