search

opacapp / multiline-collapsingtoolbar

A modified CollapsingToolbarLayout that can deal with multiline titles
Other
782 stars 113 forks source link

wrap_content of AppBarLayout #21

Open drayan85 opened 8 years ago

drayan85 commented 8 years ago

How do we can wrap_content content based on the length of title string rather not setting the fix AppBarLayout layout_height.

app:maxLines="x" here value x also not fix;

johan12345 commented 8 years ago

That's currently not possible with this library. I see why it might be useful, but I think it wouldn't be very easy to implement. You would also have to handle cases where the text is so long that it exceeds the height of the screen. Additionally, the animation looks better when the text does not occupy the full height of the AppBar in the expanded state.

As mentioned in the README, we cannot afford to spend much time to add features to this library that we ourselves don't need in our app. Additionally, more complicated features increase the effort needed to update this library with each change in the Support Library, so if someone implemented this in a Pull Request, I think we would only accept it if it did not contain too many changes to the original AOSP code.