search

opacapp / multiline-collapsingtoolbar

A modified CollapsingToolbarLayout that can deal with multiline titles
Other
782 stars 114 forks source link

Add layout_scrimMode param to hide or show child elements on content … #36

Closed dmfs closed 7 years ago

dmfs commented 7 years ago

…scrim. This is in particular useful to switch from a dark to a light toolbar, as seen in the demo.

raphaelm commented 7 years ago

Hi,

first of all, thank you very much.

If we understood it correctly, this and #37 are both not really related to the multiline functionality that this library provides, but instead a general extension of the collapsing toolbar (in contrast to #34, which is a direct improvement to the collapsing multiline text).

Therefore, we think that it should not be added to our library, as every additional feature also potentially increases the amount of work needed when updating the library to a new Support Library version. You could probably also extend our CollapsingToolbarLayout class (in your project or even as a separate open source library) to implement the same feature.

dmfs commented 7 years ago

That's right #36 and #37 are not related to multi-line at all. I don't mind to maintain my changes in my own fork, just wanted to share them with you.

raphaelm commented 7 years ago

That's right #36 and #37 are not related to multi-line at all. I don't mind to maintain my changes in my own fork, just wanted to share them with you.

Okay. Thank you very much vor that, it's really appreciated, but I think we'd rather keep this one simple here :)