search

opacapp / multiline-collapsingtoolbar

A modified CollapsingToolbarLayout that can deal with multiline titles
Other
782 stars 114 forks source link

Duplicated text for RTL languages #54

Open VitalikL opened 6 years ago

VitalikL commented 6 years ago

Addressing #33

This is not the cleanest solution, as it uses specific calculation for the X coordinate when isRTL. Also, it does not address the issue of the animation for RTL

johan12345 commented 6 years ago

Thank you for your Pull request! I just tested your version using the text that you tested in #33. The expanded state looks good, but as you said, the animation is not really complete and also, the text seems to have a wrong position (too low) in the collapsed state:

device-2018-03-01-222949

Would you like to continue to work on this so that we can have one PR that fixes all RTL problems?

VitalikL commented 6 years ago

Thanks @johan12345. It is strange that the text is very low in collapsed state, since the change introduced here is only for horizontal positioning of expanded caption. I will test master version later to see if this is a regression

johan12345 commented 5 years ago

Hey, we are currently trying to get the multiline feature merged into the official Material Components library (see the PR). However, for that, we need to make the animation work correctly in RTL languages. I tried to fix it, but so far I haven't found out how. Would you be interested in helping us with that?