Make possible to set custom collapsed title

[dryaz]

Make possible to setup custom collapsed title when you don't want to this be set by system.

Usecase: Expanded Header: "John Smith Junior, CTO of awesome company"

Collapsed Header: "John Smith" instead of "John Smith Junior, CTO..."

[johan12345]

Thanks! It looks good to me, just three minor comments:

• It would be great if you could add information about this new feature in the "Usage" section of README.md
• For consistency, could you add a getCollapsedText function to CollapsingTextHelper as well as both setCollapsedText and getCollapsedText functions to CollapsingToolbarLayout (where the latter just call through to the respective functions of mCollapsingTextHelper) so that the collapsed title can be modified programmatically? Probably the CollapsingTextHelper's setCollapsedText function then also needs to call recalculate() and clearTexture() so that the text is actually updated when it is updated at a later point in time (see the setMaxLines function).
• We normally mark all changes compared to the original Support Library code in the Java code files with // BEGIN MODIFICATION: and // END MODIFICATION comments to make it easier for us to update the library when new Support Library versions are released. Could you add these for your setCollapsedText and getCollapsedText functions?

[dryaz]

Thx for comments, sure I'll fix the pr.

вс, 3 июн. 2018 г., 13:32 Johan von Forstner notifications@github.com:

Thanks! It looks good to me, just three minor comments:

• It would be great if you could add information about this new feature in the "Usage" section of README.md
• For consistency, could you add a getCollapsedText function to CollapsingTextHelper as well as both setCollapsedText and getCollapsedText functions to CollapsingToolbarLayout (where the latter just call through to the respective functions of mCollapsingTextHelper) so that the collapsed title can be modified programmatically? Probably the CollapsingTextHelper's setCollapsedText function then also needs to call recalculate() and clearTexture() so that the text is actually updated when it is updated at a later point in time (see the setMaxLines https://github.com/dryaz/multiline-collapsingtoolbar/blob/c9973576ca46ff7202be13bbea4ef86d0345e2b3/multiline-collapsingtoolbar/src/main/java/net/opacapp/multilinecollapsingtoolbar/CollapsingTextHelper.java#L278 function).
• We normally mark all changes compared to the original Support Library code in the Java code files with // BEGIN MODIFICATION: and // END MODIFICATION comments to make it easier for us to update the library when new Support Library versions are released. Could you add these for your setCollapsedText and getCollapsedText functions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opacapp/multiline-collapsingtoolbar/pull/57#issuecomment-394152592, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVJ6K75iAIvBr8gQW1k23b68IoWK3llks5t47tagaJpZM4UUo0s .

-- Best regards, Dmitry.