opacapp / multiline-collapsingtoolbar

A modified CollapsingToolbarLayout that can deal with multiline titles
Other
782 stars 113 forks source link

Update library to Support Library version 28.0.0 #60

Closed PattaFeuFeu closed 4 years ago

PattaFeuFeu commented 5 years ago

https://developer.android.com/topic/libraries/support-library/revisions

The new Support Library version 28.0.0 is out.

From what I can see in the changelogs, it doesn’t look like any changes might affect this library.

marchy commented 5 years ago

Looks like there is a PR submitted for this here: https://github.com/opacapp/multiline-collapsingtoolbar/pull/61

Could you please merge this in for a new lib release?

johan12345 commented 5 years ago

As discussed in #61 and #63, this update is not trivial due to some changes in Android 9 where a lot of classes are library-private and this is now enforced by the system. We would need to copy a lot of additional classes to this library so that they are accessible and maintain them with future updates. I only see one sensible ways to go forward with this:

johan12345 commented 5 years ago

We have now opened a PR at https://github.com/material-components/material-components-android/pull/413 and hope this feature can then be merged into the main Material Components library.