Open pavel163 opened 5 years ago
It seems that you did update all dependencies and the compileSdkVersion etc., but did not have a look at what changed in the actual design library (now: Material Components Android) code to see what changed in the classes that we needed to copy from them. I will go through this now and update the PR accordingly.
As already mentioned by @PattaFeuFeu in #61, we probably need to copy some additional classes because they now have the @RestrictTo
annotations in the library.
Wow, there's actually a fair amount of changes in the library code and a lot of new classes that we need to copy from the Material Components Library to our library because of the RestrictTo annotations.
I compared the sources of the relevant classes from here: https://dl.google.com/dl/android/maven2/com/android/support/design/27.1.1/design-27.1.1-sources.jar to here: https://dl.google.com/dl/android/maven2/com/google/android/material/material/1.1.0-alpha02/material-1.1.0-alpha02-sources.jar
As Android 9 is starting to enforce these restrictions, there's no way around this if we want to make the library work on Android 9.
I think I'm not really motivated to do this over Christmas, if at all 😒
The much better way would be if the people at Google could finally implement our changes into the Material Components Library directly (see https://github.com/material-components/material-components-android/issues/6)
Hi @pavel163, thank you very much! @johan12345, who is responsible for this library, is currently on vacation and will have a look at this as soon as he's back, so I'd ask you to be patient for bit! :)