search

opacapp / opacclient

[unmaintained] A Java client library and an Android app to access more than 1,000 public and scientific libraries from all over the world.
https://opacapp.net
MIT License
156 stars 61 forks source link

add categories to favorites #28

Open raphaelm opened 11 years ago

raphaelm commented 11 years ago

Enable sorting the bookmarks into categories like "school", "work", "fantasy", "music", …

vivekscl commented 6 years ago

I can try working on this!

On a side note, I have a few doubts on how to go about doing this:

johan12345 commented 6 years ago

I can try working on this!

Great! :)

On a side note, I have a few doubts on how to go about doing this:

  • The categories should come from the subject attribute of the book right?
  • The sorting is automatic as in, when going to the bookmarks menu, the books are already sorted or is there a button to click for the sorting?

I think there is a slight misunderstanding here - the description was a little unclear. What @raphaelm actually meant was to add an ability to assign custom "tags" to the items on the favorites list, display these tags in the list and then allow to filter the list based on these tags. So the tags/categories are not based on properties of the item, but assigned by the user manually.

As this feature is slightly more complicated than the issue you worked on previously (especially as it involves work on the database tables as well as new things in the UI), feel free to open a pull request with "[WIP]" (work in progress) in the title and ask us when you have questions about how the UI should look like or how to best implement it in the database.

vivekscl commented 6 years ago

Oh, I understand the issue now! Seems like it will be a bit difficult as I'm still kinda new to SQL. But I'll try it out and see how it goes! Thanks for the guidance :smile: