StefRe
commented
3 years ago Regarding item 1 (get status)
I implemented it with completeable futures and I guess it's done correctly (also verifed by this small python script), but the result is prohibitively slow.
internal fun parseSearchResults(json: JSONObject): SearchRequestResult {
val availFutures = arrayListOf<CompletableFuture<Response>>()
val searchresults = json.getJSONArray("docs").map<JSONObject, SearchResult> {
SearchResult().apply {
innerhtml = "<b>${it.getString("title")}</b><br>${it.getJSONArray("author").optString(0)}"
it.getString("creationDate").run {
if (this != "null") {
innerhtml += "<br>(${this})"
}
}
type = mediaTypes[it.getJSONArray("format").optString(0)]
?: SearchResult.MediaType.NONE
id = "id/${it.getString("id")}".also {
availFutures.add(
asyncGet("$baseurl/$it/?type=1369315139&tx_find_find[data-format]=json-holding-status&tx_find_find[format]=data",
true).whenComplete { response: Response?, _: Throwable? ->
if (response != null) {
status = when (try {
JSONObject(response.body()?.string()).getInt("status")
} catch (e: Exception) {
0
}) {
1 -> SearchResult.Status.GREEN
2 -> SearchResult.Status.YELLOW
3 -> SearchResult.Status.RED
else -> SearchResult.Status.UNKNOWN
}
} else {
status = SearchResult.Status.UNKNOWN
}
})
}
}
}
CompletableFuture.allOf(*availFutures.toTypedArray()).join()
return SearchRequestResult(searchresults, json.getInt("numFound"), 1)
}Even with 1000 Mbps link speed it takes almost 10 seconds for the search results to show up. It seems that there's nothing we can do to speed this up as the web catalog needs roughly the same time as the app:
Web catalog: (20 status queries)
App: (the search query itself followed by the 20 status queries)
The queries appear to be blocked on the server side. For the web catalog, this looks OK as you see the search results after 1-2 seconds and then the pending status icons 
get updated to 
, 
or 
within the next 8 seconds (see example). The app, however, waits for all the status queries be completed and only then shows the results including status markers.
As far as I understand it's not possible in the app to update the status markers after the results are shown. If so I don't want to include the availability status in the app as it simply takes way too long to get the search results.
johan12345
raphaelm
The API works (catalog and account features) but there are still some TODOs to be completed from #553:
[ ] get status: low priority due to the limited usefulness of the status as in many many cases it just says "click for more information about availability" (in the online web catalogue), so you'll have to open the details page anyway.
Implementation idea: use asyncGet and then put all the CompletableFutures constructed into a list before calling get() on them (thanks to @johan12345 here and here)
--> to be put off until #607 is implemented
[x] references: libero links must be resolved to
rsnentries in current SLUB catalog and they then in turn toidentries (similar to next below) Resolved by #613.[x]
idof reserved itemsbcentries to be resolved toidentries by intercepting redirection (modifygetResultByIdto take a prefixedidand resolve thisidto anidentry if the prefix is not"id". AdoptgetShareUrl,parseSearchResults,parseResultByIdandparseAccountDataaccordingly.)Resolved by #598.
[x]
idof lent itemsbcentries to be resolved toidentries by intercepting redirection (same as above)Resolved by #598.
[ ] actual ready date of stack request: works but could be refined, need more examples to examine
[x] inter-library loans renewability: need example (
X_is_flrenewablefield exists in json but not sure if it's actually used/properly set) Resolved by #611.[ ] getSupportedLanguages and setLanguage: low priority as all information concerning inter-library loans, most other account information and most of the captions/titles for links remain in German even in the English version of the online catalog