search

opain / GenoPred

Genotype-based Prediction (GenoPred)
https://opain.github.io/GenoPred/
GNU General Public License v3.0
65 stars 21 forks source link

Unnecessary per-chromosome loop in polygenic_score_file_creator_lassosum_plink2.R #67

Closed remomomo closed 2 years ago

remomomo commented 2 years ago

https://github.com/opain/GenoPred/blob/de69fdf79fd3d9760cb910fc5b6217a3fbe478c2/Scripts/polygenic_score_file_creator_lassosum/polygenic_score_file_creator_lassosum_plink2.R#L244

Hi Ollie,

I believe the loop over the single chromosomes is not necessary here. Correct me if I'm wrong.

cheers,

Remo

opain commented 2 years ago

You are absolutely correct. Apologies. The output won't be affected but it will run faster. Thank you for highlighting.

I have just pushed this change: https://github.com/opain/GenoPred/pull/68