[IE11] Fixed support check for Event.constructor

opal / opal-browser

Browser support for Opal.

MIT License

115 stars 36 forks source link

[IE11] Fixed support check for Event.constructor #61

Closed MichaelSp closed 7 years ago

MichaelSp commented 8 years ago

This check works on IE11

elia commented 8 years ago

@meh just as a remainder, this change is necessary since rescue now ignores JS errors (except maybe those inheriting from Error).

MichaelSp commented 8 years ago

anything I can do to get this released?

MichaelSp commented 8 years ago

ping @meh @elia

MichaelSp commented 7 years ago

necessary change not merged since 6 month? Not so necessary?

elia commented 7 years ago

@MichaelSp I was about to suggest to change the PR to rescue JS::Exception instead of using try/catch. But looking again try/catch won't break backwards compatibility.

Please ping me if you submit other PRs like this and I'll try my best to help and get things merged.

MichaelSp commented 7 years ago

Thanks elia! I currently have no other PR.