search

opal / opal-browser

Browser support for Opal.
MIT License
115 stars 36 forks source link

all specs passing integrated server side specs with hyper-spec #85

Open catmando opened 3 years ago

catmando commented 3 years ago

All specs pass if you run bundle exec rake

However I do not understand how spec/runner.rb is supposed to work, and its just failing with some message about chomp.

Not sure how to fix that.

catmando commented 3 years ago

@hmdne updated the flag to be server_side_test per your request, and did a little more cleanup and comments.

catmando commented 3 years ago

okay, so hyper-spec now will run on Rack, and so that is cleaned up, and while I was working on that, somebody at the slack site found some bugs in canvas which I fixed, and added some specs.

hmdne commented 3 years ago

I did a different approach, by making default mean selenium_chrome. I will try to backport from this PR as much as possible in the following days.