search

opal / opal-rspec-rails

bindings between `opal-rails` and `opal-rspec`
MIT License
3 stars 2 forks source link

runs with opal 0.8 and 0.9, fixed two broken specs #3

Closed catmando closed 5 years ago

catmando commented 8 years ago

had to remove the on_exit thing, and dependencies on 0.9 std libs console, and platform.

Also fixed two broken specs

wied03 commented 8 years ago

@catmando - Talking with Elia about this and the best strategic move

wied03 commented 8 years ago

@elia - It's been forever since I've worked on a lot of this. I reviewed your 11 June comment on gitter about avoiding platform specific checks inside opal-rspec. That sounds fine to be but I don't really see how at_exit helps with that. Regardless of at_exit, the autorun method has to call Kernel#exit in some fashion. It seems to me that we'd be better off focusing our efforts on containing platform specific exit code within Opal behind Kernel#exit. The browser for example could be a noop. It really doesn't matter from an opal-rspec standpoint since the formatter is listening/displaying.

elia commented 5 years ago

Closing this, stuff have changed on both this repo and opal-rspec, probably the problem solved by this PR is fixed.