search

opark03 / ds2006-park-olivia

0 stars 0 forks source link

deliverable2-simulation-error Grade #15

Closed eanelson01 closed 6 months ago

eanelson01 commented 6 months ago

Grade: 1

Formatting

This is minor, but one of your headers says "Concepts Averview" but I think you meant "Concepts Overview."

Plots:

For the log2 plots, can you indicate in the y-axis label that they are on the log2 scale?

Interpretation:

Can you explain a bit more why the order of the probabilities switch going from absolute error to relative error? Try to think of the magnitude of the probabilities and their variance (the variance of a proportion or probability is p * (1-p)). Also, think about what is in the denominator of the relative error calculation.

Great job on the rest and let me know if there's anything I can clarify!

opark03 commented 6 months ago

Thank you for your feedback! I resubmitted and added a section "Magnitude of Absolute and Relative Error Explanation", but please let me know if it does not fully address your comment!

eanelson01 commented 6 months ago

Grade: 2

Great job!