opauth / opauth

Multi-provider authentication framework for PHP
http://opauth.org
MIT License
1.65k stars 243 forks source link

Rejecting from using unsafe serialize/unserialize #116

Closed FedorKononov closed 6 years ago

clayliddell commented 7 years ago

The calls to serialize()/unserialize() functions do need to be changed out since opauth is currently vulnerable to PHP Object Injection. However, you only replaced the calls to serialize() with json_encode() in your pull request which would make it so that a json encoded value would be sent to callback.php to be unserialized. You need to replaces unserialize() with json_decode() in order to keep from breaking the build.