Not valid json for apps.json file

opawg / user-agents-v2

Comprehensive open-source collection of broadly-compatible regular expression patterns to identify and analyze podcast player user agents.

MIT License

43 stars 17 forks source link

Not valid json for apps.json file #31

Closed majkiee closed 2 months ago

majkiee commented 2 months ago

The following line does not pass json validation and parsing. It produces the following error Invalid escape character in string https://github.com/opawg/user-agents-v2/blob/fb22360457a2bf8da6de59b0bf2941164bc854c0/src/apps.json#L1613

jamescridland commented 2 months ago

That's my fault entirely, sorry.

I have commit rights, but hoped I'd left pull requests for another contributor rather than simply push the requests through. I think I did push one request through in error. I've removed that line.

My apologies.

majkiee commented 2 months ago

it happens to the best of us, thanks for the quick fix 👍🏻

majkiee commented 2 months ago

@jamescridland one recommendation would be to put a github action in place to validate files on PR and commit to stop bad files from coming through. Example: https://github.com/marketplace/actions/json-yaml-validate

jamescridland commented 2 months ago

I'll let @johnspurlock make that decision. Thank you!

johnspurlock commented 2 months ago

This repo already has such a check - in this case the commit was pushed directly, not as a PR, where the check can stop a bad merge.