ClusteringModel is not sufficiently general; it should be renamed to EuclidianClusterer as it assumes that data points are points in a Euclidian space. All subclasses should be named accordingly.
Since geopandas is a problematic dependency (see #45), all geo-analytics-related code should be bundled in a new package geoanalytics.
This package should also contain all the utils that depend on geopandas.
Restructuring of the package:
clustering/base/clustering.py -> clustering/clustering_base.py
clustering/sklearn_clustering.py: shall contain sklearn base classes and specialisations (using prefix "Sk" not "SK")
clustering/coordinate_clustering: move to geoanalytics
ClusteringModel
is not sufficiently general; it should be renamed toEuclidianClusterer
as it assumes that data points are points in a Euclidian space. All subclasses should be named accordingly.Since geopandas is a problematic dependency (see #45), all geo-analytics-related code should be bundled in a new package
geoanalytics
. This package should also contain all the utils that depend on geopandas.Restructuring of the package: clustering/base/clustering.py -> clustering/clustering_base.py clustering/sklearn_clustering.py: shall contain sklearn base classes and specialisations (using prefix "Sk" not "SK") clustering/coordinate_clustering: move to
geoanalytics