search

opcode81 / sensAI

The Python library for sensible AI.
https://opcode81.github.io/sensAI/docs/
Other
40 stars 3 forks source link

Geopandas optional dependency #50

Closed schroedk closed 3 years ago

schroedk commented 3 years ago

Introduce new package geoanalytics, in order to encapsulate functionality related to geopandas. Make geopandas an addtional dependency.

MischaPanch commented 3 years ago

@schroedk Btw, I glanced over the recent changes on develop and noticed that after your changes in cache_azure, the docstring of AzureLazyBatchCommitTable is no longer correct. If you want, you could add the fix to this PR (or directly to develop, of course)

schroedk commented 3 years ago

@schroedk Btw, I glanced over the recent changes on develop and noticed that after your changes in cache_azure, the docstring of AzureLazyBatchCommitTable is no longer correct. If you want, you could add the fix to this PR (or directly to develop, of course)

@MischaPanch Could you please explain this in more detail? :)

MischaPanch commented 3 years ago

@schroedk Btw, I glanced over the recent changes on develop and noticed that after your changes in cache_azure, the docstring of AzureLazyBatchCommitTable is no longer correct. If you want, you could add the fix to this PR (or directly to develop, of course)

@MischaPanch Could you please explain this in more detail? :)

Here the class docstring """ Wrapper for an Azure table, which allow for convenient insertion via lazy batch execution per partition. Uses a priority queue to manage order of partitions to be committed. To execute insertions, call :func:LazyBatchCommitTable.commit """

The last sentence is wrong - the class has a different name and there is no method called "commit". Also allow->allows in the first sentence

schroedk commented 3 years ago

@schroedk Btw, I glanced over the recent changes on develop and noticed that after your changes in cache_azure, the docstring of AzureLazyBatchCommitTable is no longer correct. If you want, you could add the fix to this PR (or directly to develop, of course)

@MischaPanch Could you please explain this in more detail? :)

Here the class docstring """ Wrapper for an Azure table, which allow for convenient insertion via lazy batch execution per partition. Uses a priority queue to manage order of partitions to be committed. To execute insertions, call :func:LazyBatchCommitTable.commit """

The last sentence is wrong - the class has a different name and there is no method called "commit". Also allow->allows in the first sentence

Thanks for pointing out, I will fix it on a different branch as it is used in a different project.