Open dm-pf opened 1 year ago
Hi, thanks for this awesome package ❤️ .
I've tried using it inside my Laravel Nova project - and the way Nova loads external-to-nova URIs is by loading them in a dialog window through an . When that happens I get this window:</p> <p><img referrerpolicy="no-referrer" src="https://user-images.githubusercontent.com/100700999/231823448-43d2f8bd-1504-448b-aed7-d58d1c8080d9.png" alt="image" /></p> <p>It seems that because the /log-viewer is loaded through an iframe - it loses track of the correct URI path to load its <code>api/folders</code>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/arukompas"><img src="https://avatars.githubusercontent.com/u/8697942?v=4" />arukompas</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hey @dm-pf can you share how you've added a link to the Log Viewer?</p> <p>I'm not a Nova user, but I think what you're looking for is this:</p> <pre><code class="language-php">use Laravel\Nova\Menu\MenuItem; MenuItem::externalLink('Log Viewer', route('log-viewer.index'))</code></pre> <p>This is taken from Nova v4 docs btw:</p> <p><a href="https://nova.laravel.com/docs/4.0/customization/menus.html#menu-items">https://nova.laravel.com/docs/4.0/customization/menus.html#menu-items</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dm-pf"><img src="https://avatars.githubusercontent.com/u/100700999?v=4" />dm-pf</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hi @arukompas - using <code>MenuItem::externalLink()</code> (or <code>MenuItem::path()->external()</code> in my case) redirects to that URL which is exactly what I did after stumbling upon the above issue. Ideally, I would like to use it this way instead:</p> <pre><code class="language-php">MenuSection::make('Log Viewer') ->path('/log-viewer') ->icon('lightning-bolt'),</code></pre> <p>Because that way I don't need to "get out" of my Dashboard and I can just load external tools in a dialog window. E.g. Laravel Horizon works fine this way.</p> <p>Even though my use case is a bit particular (I doubt many people are using Nova) - I thought that reporting this would be a good idea because the issue itself could be triggered in other similar situations if not handled properly.</p> <p>Thanks.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/asad6ek"><img src="https://avatars.githubusercontent.com/u/53338664?v=4" />asad6ek</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <img width="419" alt="Screenshot 2023-06-12 at 17 33 35" src="https://github.com/opcodesio/log-viewer/assets/53338664/f81c554b-0297-443c-8f57-a93f0b636a32"> <p>how can i use log-viewer in laravel nova. v1.9.1 is working but 2.* is not working</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Hi, thanks for this awesome package ❤️ .
I've tried using it inside my Laravel Nova project - and the way Nova loads external-to-nova URIs is by loading them in a dialog window through an