Refactor client creation to test CSV operations

bcrochet commented 1 year ago

Description of PR

In order to make the csv.go code testable, a pretty major refactor needed to occur. The clients used needed to be injected in order to make replacement with a fake possible. This now limits the number of places that the client is instantiated.

Signed-off-by: Brad P. Crochet brad@redhat.com

Fixes #216

Changes (required)

Move client creation up into the cmds that use one
Create the dynamic and olm clients inside the operatorClient
Add new methods for olm and unstructured to the operator.Client interface
Simplify the csv.go to remove some unnecessary code
Add tests for csv.go

Checklist (required)

[X] I have reviewed and followed the contribution guidelines
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation if needed
[X] I have checked that my changes pass all tests

bcrochet commented 1 year ago

Marked as WIP as this should go in after #253 and #256

exe-prow-github-app[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yashoza19

Associated issue: #101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)~~ [yashoza19] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

acmenezes commented 1 year ago

Pretty nice one! @bcrochet I wonder if we can get a walk through on this one on showtime. /lgtm

opdev / opcap