Closed acmenezes closed 2 years ago
@yashoza19 please lgtm if you are performing initial review rather than approving. additionally have the checks that failed been reviewed or are they non-consequential?
TBH,
@yashoza19 please lgtm if you are performing initial review rather than approving. additionally have the checks that failed been reviewed or are they non-consequential?
Empty line definitely should be removed before merging.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bcrochet, yashoza19
Associated issue: #286
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: acmenezes adcmenezes@gmail.com
Description of PR
Exit function with code 0 was masking errors and panics.
Fixes #286
Changes (required)
Checklist (required)
References (optional)