opdev / opcap

Apache License 2.0
3 stars 15 forks source link

Remove code that was masking errors and panics by running #289

Closed acmenezes closed 2 years ago

acmenezes commented 2 years ago

Signed-off-by: acmenezes adcmenezes@gmail.com

Description of PR

Exit function with code 0 was masking errors and panics.

Fixes #286

Changes (required)

References (optional)

mrhillsman commented 2 years ago

@yashoza19 please lgtm if you are performing initial review rather than approving. additionally have the checks that failed been reviewed or are they non-consequential?

bcrochet commented 2 years ago

TBH,

@yashoza19 please lgtm if you are performing initial review rather than approving. additionally have the checks that failed been reviewed or are they non-consequential?

Empty line definitely should be removed before merging.

exe-prow-github-app[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, yashoza19

Associated issue: #286

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)~~ [yashoza19] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment