Add operator_install tests

opdev / opcap

Apache License 2.0

3 stars 15 forks source link

Add operator_install tests #304

Closed trgeiger closed 1 year ago

trgeiger commented 2 years ago

Closes [#279]

Description of PR

Adds operator_install_test.go which can be tested the same way as other go unit tests.

Fixes #279

Changes (required)

Added operator_install_test.go
Added logger initialization to capability/suite_test.go

Checklist (required)

[x] I have reviewed and followed the contribution guidelines
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation if needed
[x] I have checked that my changes pass all tests

trgeiger commented 2 years ago

@bcrochet integrated your suggestions (I think), wondering in particular about how I moved auditFn and auditCleanupFn initializations

trgeiger commented 2 years ago

Everything is squashed to 1 commit now. I think I got all the linting errors you pointed out @bcrochet . I think the rest of operator_install_test that doesn't have coverage consists of functions tested in other unit tests like subscription_test and report_test. As for testing the with*() functions, sounds like we could/should do that in another PR that focuses on their specific test suite. Please let me know if I missed or forgot anything you think needs to be in here!

exe-prow-github-app[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bcrochet, skattoju Once this PR has been reviewed and has the lgtm label, please assign madorn for approval by writing /assign @madorn in a comment. For more information see:The Kubernetes Code Review Process.

Associated issue: #279

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

exe-prow-github-app[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.

acmenezes commented 1 year ago

@trgeiger I think, because of the errors on github actions, it may be easier to just grab those changes and open a new PR with the same thing. We couldn't see why this still fails.