opdev / opcap

Apache License 2.0
3 stars 15 forks source link

Remove client requirement from list command #309

Closed bcrochet closed 1 year ago

bcrochet commented 1 year ago

Description of PR

The base list command should not create a k8s client. Only the 'list packages' command needs the client. The upcoming 'list bundles' command does not. So, this patch moves the client into the child command instead of the base 'list' command.

Signed-off-by: Brad P. Crochet brad@redhat.com

Fixes #308

Changes (required)

Checklist (required)

acmenezes commented 1 year ago

/lgtm

acmenezes commented 1 year ago

/approve

exe-prow-github-app[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acmenezes

Associated issue: #101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)~~ [acmenezes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment